Skip to content

[DowngradePhp84] Downgrade RoundingMode enum #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 13 commits into from
Dec 20, 2024
Merged

[DowngradePhp84] Downgrade RoundingMode enum #260

samsonasik merged 13 commits into from
Dec 20, 2024

Conversation

@jorgsowa
Copy link
Contributor

@jorgsowa jorgsowa commented Dec 19, 2024

Downgrade rule for rectorphp/rector-src#6369

@samsonasik
Copy link
Member

samsonasik commented Dec 19, 2024

Register the rule at

https://github.com/rectorphp/rector-downgrade-php/blob/main/config/set/downgrade-php84.php

@samsonasik
Copy link
Member

samsonasik commented Dec 19, 2024

Please run:

vendor/bin/rector && composer fix-cs

to fix CI

@samsonasik
Copy link
Member

samsonasik commented Dec 20, 2024

Thank you @jorgsowa

@samsonasik samsonasik enabled auto-merge (squash) December 20, 2024 00:04
@samsonasik samsonasik merged commit 183795c into rectorphp:main Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgsowa @samsonasik